codeant-ai-for-open-source[bot] commented on code in PR #45035:
URL: https://github.com/apache/superset/pull/45035#discussion_r4201318449
##########
.github/workflows/docker.yml:
##########
@@ -280,10 +291,15 @@ jobs:
docker-build:
name: docker-build
needs: [setup_matrix, changes]
+ # A push build exists to publish images. Without the Docker Hub
+ # credentials (e.g. on a fork or mirror) it can publish nothing, so it
+ # is skipped there; pull_request builds, which only validate that the
+ # images build, run everywhere.
if: >-
- needs.changes.outputs.python == 'true' ||
- needs.changes.outputs.frontend == 'true' ||
- needs.changes.outputs.docker == 'true'
+ (github.event_name != 'push' || needs.setup_matrix.outputs.has-secrets)
&&
Review Comment:
**Suggestion:** `docker-build-plan.sh` uses `--load` for version-branch
pushes, so they do not publish; this guard still requires Docker Hub secrets
and skips their build validation on mirrors.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Incorrect
condition logic`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=07dfc48009a04f7e940291e1e1a441c4&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=07dfc48009a04f7e940291e1e1a441c4&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** .github/workflows/docker.yml
**Line:** 298:299
**Comment:**
*Incorrect Condition Logic: `docker-build-plan.sh` uses `--load` for
version-branch pushes, so they do not publish; this guard still requires Docker
Hub secrets and skips their build validation on mirrors.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45035&comment_hash=38792ddeaa14a6bcded8ea6bc2e19ba600601f38bde8bd1d03eae9008cb9090b&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45035&comment_hash=38792ddeaa14a6bcded8ea6bc2e19ba600601f38bde8bd1d03eae9008cb9090b&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
