gkneighb commented on PR #43570: URL: https://github.com/apache/superset/pull/43570#issuecomment-6029761563
Rebased onto current master. CI here is down to **one** failing test, `test_dispatchers_do_not_branch_on_registered_chart_types` from #44746, flagging `chart_helpers: viz_type == "heatmap_v2"` — the line I wrote during this rebase adopting master's `with_x_axis_column()` helper. The same single test fails on all four chart-plugin PRs (#43567, #43570, #43571, #43573) for the same structural reason: that guard flags dispatcher branches keyed on *registered* chart types, so registering a new type is enough to turn pre-existing code into a violation. It needs the per-type behavior moved into the new plugin hooks rather than a line edit. I've written the full analysis and two questions for @rusackas in one place to avoid four parallel threads: https://github.com/apache/superset/pull/43573#issuecomment-6029757928 Otherwise this branch is rebased, mergeable, and green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
