aminghadersohi commented on code in PR #44657:
URL: https://github.com/apache/superset/pull/44657#discussion_r4202520130
##########
superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/utilities.ts:
##########
@@ -1154,14 +1498,47 @@ class PivotData {
* switch, and records that resolve to the same formatter still accumulate.
*/
pushAllTotal(record: PivotRecord): void {
Review Comment:
This docblock still says the slot is rebuilt whenever the formatter changes
and that same-formatter records accumulate, but the method now builds once from
the first record and never rebuilds, so it invites restoring the rebuild.
(Prose only: the docblock starts above the hunk.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
