SEPURI-SAI-KRISHNA commented on issue #45042:
URL: https://github.com/apache/superset/issues/45042#issuecomment-6036088198
Correcting the suggested fix above, which is not right and I should not have
stated it that confidently.
`all` to `any` rejects a mapping that renames onto a label it vacates
itself. `{"a": "b", "b": "d"}` on `[a, b, c]` gives `['b', 'd', 'c']`, which is
unique, and master accepts it today. Flagged by CodeAnt on #45043.
There is also a second form of the same bug that neither `all` nor `any`
catches: `{"a": "z", "b": "z"}` gives `['z', 'z', 'c']`, with no target present
beforehand for a presence test to find.
The guard is asking whether a target label exists when the thing that
matters is whether the result holds a duplicate. #45043 checks that instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
