codeant-ai-for-open-source[bot] commented on code in PR #45043:
URL: https://github.com/apache/superset/pull/45043#discussion_r4205835000
##########
superset/utils/pandas_postprocessing/rename.py:
##########
@@ -49,7 +49,7 @@ def rename(
except (IndexError, KeyError) as err:
raise InvalidPostProcessingError from err
- if all(new_name in _rename_level for new_name in columns.values()):
+ if any(new_name in _rename_level for new_name in columns.values()):
Review Comment:
✅ **CodeAnt verified this suggestion was addressed in subsequent commits and
marked this thread resolved** as of `3b73eb6`.
The code applies the rename to an empty slice and compares the resulting
duplicate-label count with the original count. This allows `A`→`B`, `B`→`D`
when the rename does not introduce duplicates.
<sub>If that's not right, unresolve this thread and CodeAnt will leave it
open.</sub>
<!-- codeant-auto-resolve-reply -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
