FrancescoCastaldi commented on PR #45051:
URL: https://github.com/apache/superset/pull/45051#issuecomment-6038139669
Hi @sadpandajoe @rusackas,
This PR addresses issue #45050 by resolving a reverse-portal DOM node
contention issue in the horizontal filter bar.
When a filter has `requiredFirst` enabled, `FilterControls` was passing
`forceRender={hasRequiredFirst}` to `DropdownContainer`, causing Ant Design's
closed `Popover` to mount in hidden DOM. During transient re-measurement after
a cross-filter selection, the hidden popover's `OutPortal` stole filter
elements from the horizontal bar, causing native filters to collapse and
disappear.
The fix removes `forceRender` from `DropdownContainer` and includes
comprehensive regression tests in `FilterControls.overflow.test.tsx` and
`DropdownContainer.test.tsx` (all passing).
Whenever you have a moment, could you please take a look for review and
merge? Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
