codeant-ai-for-open-source[bot] commented on code in PR #45057:
URL: https://github.com/apache/superset/pull/45057#discussion_r4209744997
##########
superset/commands/sql_lab/export.py:
##########
@@ -135,7 +135,16 @@ def run(
sql = self._query.select_sql
limit = None
else:
- sql = self._query.executed_sql
+ # Use the full original SQL (self._query.sql) instead of
+ # self._query.executed_sql. The executed_sql field only holds
+ # the last statement executed (e.g. the SELECT), because
+ # sql_lab.py overwrites it on each loop iteration. When a
+ # multi-statement query uses session variables (SET @var =
...),
+ # those SET statements are lost from executed_sql, so
re-running
+ # it on a fresh connection leaves the variables undefined
(NULL)
+ # and the WHERE clause matches nothing, producing an empty CSV.
+ # Using query.sql preserves all statements including the SETs.
+ sql = self._query.sql
Review Comment:
**Suggestion:** For uncached scripts with DML or DDL before the final
SELECT, `get_df` replays those statements during export, so mutations can
happen twice or the export can fail on existing objects.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Logic error`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=b4a7d976ac7e4ba582bd2b7f9ceabb4d&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=b4a7d976ac7e4ba582bd2b7f9ceabb4d&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/commands/sql_lab/export.py
**Line:** 147:147
**Comment:**
*Logic Error: For uncached scripts with DML or DDL before the final
SELECT, `get_df` replays those statements during export, so mutations can
happen twice or the export can fail on existing objects.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45057&comment_hash=238f05770066c6b99ffbb37be520d5b2bd96e3554d4179deda75b69d007887f3&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45057&comment_hash=238f05770066c6b99ffbb37be520d5b2bd96e3554d4179deda75b69d007887f3&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
