codeant-ai-for-open-source[bot] commented on code in PR #45055:
URL: https://github.com/apache/superset/pull/45055#discussion_r4210455061
##########
superset-frontend/src/utils/semanticViewStructure.ts:
##########
@@ -94,28 +91,19 @@ export const fetchSemanticViewStructure = async (
semanticViewId: number | string,
): Promise<SemanticViewStructure> => {
const endpoint = `/api/v1/semantic_view/${semanticViewId}/structure`;
- try {
- const response = await cachedSupersetGet({ endpoint });
- const {
- name,
- dimensions = [],
- metrics = [],
- semantic_selection_version,
- } = response.json?.result ?? {};
- return {
- name,
- dimensions,
- metrics,
- semantic_selection_version: semantic_selection_version ?? undefined,
- };
- } catch (error) {
- // cacheWrapper caches the promise itself and never evicts on rejection, so
- // a single failed response would poison this endpoint for the rest of the
- // page session. Evict on error so a later call refetches โ mirroring the
- // regular-dataset drill branch (hooks/apiResources/datasets.ts).
- supersetGetCache.delete(endpoint);
- throw error;
- }
+ const response = await cachedSupersetGet({ endpoint });
Review Comment:
**Suggestion:** After the first successful fetch, this endpoint stays cached
for the page session; upstream schema changes leave dimensions and metrics
stale for later consumers.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Cache`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=8c4f46e04cc14164aa2e9a3b78d89d1b&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=8c4f46e04cc14164aa2e9a3b78d89d1b&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/src/utils/semanticViewStructure.ts
**Line:** 94:94
**Comment:**
*Cache: After the first successful fetch, this endpoint stays cached
for the page session; upstream schema changes leave dimensions and metrics
stale for later consumers.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45055&comment_hash=7afb92d0d31fa2b36fd8a372a1879064dd04cfe842c8ae0c94943c9bb31440cc&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45055&comment_hash=7afb92d0d31fa2b36fd8a372a1879064dd04cfe842c8ae0c94943c9bb31440cc&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
