codeant-ai-for-open-source[bot] commented on code in PR #45061: URL: https://github.com/apache/superset/pull/45061#discussion_r4211406000
########## superset/semantic_layers/api.py: ########## @@ -84,6 +86,30 @@ logger = logging.getLogger(__name__) +def _refuse_disabled_semantic_layers() -> FlaskResponse | None: + """Refuse semantic API dispatch before authentication or handler side effects.""" + if not is_semantic_layers_enabled(): + return BaseSupersetApi.response(404, message="Not found") Review Comment: **Suggestion:** When the flag is off, this calls the instance method `response` without an API instance, raising `TypeError` instead of returning the promised 404. **Assessment:** ๐ `Major` ยท ๐ `Occurrence: Often` ยท ๐ท๏ธ `Type error` [](https://docs.codeant.ai/cli/resolve-pr-comments-skill) [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=478e8468bb14408098946e485f5a3c41&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=478e8468bb14408098946e485f5a3c41&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) <details> <summary><b>Prompt for AI Agent ๐ค </b></summary> ```mdx This is a comment left during a code review. **Path:** superset/semantic_layers/api.py **Line:** 92:92 **Comment:** *Type Error: When the flag is off, this calls the instance method `response` without an API instance, raising `TypeError` instead of returning the promised 404. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45061&comment_hash=474a3eb7b08d753f7865fde861140ffdcb488d82a93519c2bb18ed2193a507f7&reaction=like'>๐</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45061&comment_hash=474a3eb7b08d753f7865fde861140ffdcb488d82a93519c2bb18ed2193a507f7&reaction=dislike'>๐</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
