codeant-ai-for-open-source[bot] commented on code in PR #45059:
URL: https://github.com/apache/superset/pull/45059#discussion_r4210130579
##########
superset/commands/dashboard/permalink/create.py:
##########
@@ -97,14 +97,30 @@ def run(self) -> str:
assert entry.id # for type checks
return encode_permalink_key(key=entry.id, salt=self.salt)
- # Create new entry with current algorithm
- entry = KeyValueDAO.create_entry(
- resource=self.resource,
- key=uuid_key,
- value=value,
- codec=self.codec,
- )
- db.session.flush()
+ # Create new entry with current algorithm.
+ #
+ # The uuid is deterministic, so concurrent identical requests (same
user,
+ # dashboard and state) all try to insert the same uuid. The lookup
above and
+ # this insert are not atomic, so the unique index is the ultimate
arbiter:
+ # the insert runs inside a SAVEPOINT and, if a concurrent request won
the
+ # race, we join the winner's entry instead of failing the request.
+ try:
+ with db.session.begin_nested():
+ entry = KeyValueDAO.create_entry(
+ resource=self.resource,
+ key=uuid_key,
+ value=value,
+ codec=self.codec,
+ )
+ db.session.flush()
+ except IntegrityError:
+ # The SAVEPOINT is rolled back and the session is still usable. The
+ # winner's row is committed by now (READ COMMITTED, the default for
+ # MySQL and PostgreSQL metadata databases), so re-read it. If
nothing
+ # is found, this was not the expected duplicate, so re-raise.
+ entry = KeyValueDAO.get_entry(self.resource, uuid_key)
Review Comment:
**Suggestion:** `READ COMMITTED` is only the default; with configured
`REPEATABLE READ`, this reread can use the earlier snapshot, return `None`, and
re-raise the duplicate.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Race condition`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=83f4caff60504280b486d8712ee2cad3&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=83f4caff60504280b486d8712ee2cad3&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/commands/dashboard/permalink/create.py
**Line:** 121:121
**Comment:**
*Race Condition: `READ COMMITTED` is only the default; with configured
`REPEATABLE READ`, this reread can use the earlier snapshot, return `None`, and
re-raise the duplicate.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45059&comment_hash=cabe6374ec672ec2825eaaea9903abc0feadb990aada700b5e4c191043566346&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45059&comment_hash=cabe6374ec672ec2825eaaea9903abc0feadb990aada700b5e4c191043566346&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
