gabotorresruiz commented on code in PR #45056: URL: https://github.com/apache/superset/pull/45056#discussion_r4211941902
########## superset-frontend/src/views/App.tsx: ########## @@ -146,8 +146,15 @@ const lockedShellCss = css` overflow: hidden; Review Comment: Not a blocker, and not a regression either since the merge base cuts off the same 60px. But the reasoning in the description for leaving `lockedShellCss` alone does not quite cover SQL Lab. Explore gets away with it because `ExploreViewContainer`'s global gives `body` a definite `height: 100vh`, so the 100vh locked shell has negative free space and flex shrinks inside the shortened `#app`. `SqlLabGlobalStyles` only sets `min-height: max(100vh, 500px)` plus `overflow: hidden`, so `body` just grows to 860px, nothing shrinks, and the hidden overflow leaves the last 60px unreachable rather than a page scroll away. Measured with a 60px banner at an 800px viewport: panel closed, the results pane bottom moves from 860 on the merge base to 800 here; panel open, it stays at 860 on both. Worth a sentence in the description, or happy to leave it for whoever picks up the locked shell next. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
