codeant-ai-for-open-source[bot] commented on code in PR #45067:
URL: https://github.com/apache/superset/pull/45067#discussion_r4214910287
##########
superset/mcp_service/chart/tool/get_chart_data.py:
##########
@@ -547,11 +551,15 @@ async def execute_chart_data( # noqa: C901
)
logger.info("Getting data for chart %s: %s", chart_id, chart_name)
- # Guests skip the RBAC check (authorize_query covers it) but keep the
+ # Table guests skip the RBAC check (authorize_query covers it) but
keep the
# existence check, so a deleted dataset still returns
# DatasetNotAccessible.
- validation_result = validate_chart_dataset(
- chart_datasource_id, check_access=not guest_scope.is_guest_read()
+ validation_result: DatasetValidationResult = (
+ validate_chart_semantic_view(chart_datasource_id)
+ if chart_datasource_type == DatasourceType.SEMANTIC_VIEW.value
+ else validate_chart_dataset(
+ chart_datasource_id, check_access=not
guest_scope.is_guest_read()
+ )
)
Review Comment:
**Suggestion:** For guest reads, this branch checks direct view access
before `authorize_query` adds dashboard context, rejecting views guests can
access through an authorized dashboard.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Security`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=a9778255eb7043f6976eb90c034c3760&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=a9778255eb7043f6976eb90c034c3760&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/mcp_service/chart/tool/get_chart_data.py
**Line:** 557:563
**Comment:**
*Security: For guest reads, this branch checks direct view access
before `authorize_query` adds dashboard context, rejecting views guests can
access through an authorized dashboard.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45067&comment_hash=a0f63706d3644416aed071b2e899364a47d8b26c7622a969cf65252cc2c2cc72&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45067&comment_hash=a0f63706d3644416aed071b2e899364a47d8b26c7622a969cf65252cc2c2cc72&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
