aminghadersohi commented on PR #45084: URL: https://github.com/apache/superset/pull/45084#issuecomment-6058532191
## AI review at head b2558a6d715a772643dfb8c1a6022e8d4c30f264 **Verdict: CLEAN** Reviewed the full 14-file diff against master, including the merged prerequisite changes, for correctness, regressions, security against SECURITY.md, and test coverage. No actionable findings identified. Checked that compaction changes only listed descriptions, leaves schemas/annotations and call validation intact, and preserves registered definitions for calls. Reviewed both startup paths, shared search serialization, returned-error logging, editorial trims, documentation, and inventory/authorization contract tests. Validation with FastMCP 3.4.7 and MCP 1.29.1: - `test_native_tool_surface.py`, `test_mcp_server.py`, `test_middleware_logging.py`, and `test_tool_description_constraints.py`: **266 passed**. - `test_tool_search_transform.py`: **104 passed**. - Full-diff `git diff --check`: passed. The local HTTP health endpoint was unavailable; these unit tests ran independently. No fixes, commits, or pushes were needed. Live head was reverified before posting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
