aminghadersohi commented on PR #45081: URL: https://github.com/apache/superset/pull/45081#issuecomment-6058514415
## AI review at head e388bda075d893b09494ada7c2308bc26f08fd1c **Verdict: CLEAN** Reviewed the full five-file diff against master for correctness, regressions, security (against SECURITY.md), and test coverage. No actionable findings. Preserving `ToolResult.is_error` fixes proxied error responses without changing successful content, structured output, or authorization. The new contract tests cover discovery/schema fidelity, direct/proxy parity, denied calls, token scopes, restricted principals, permission revocation, and removed tools. Validation: - Touched unit tests: `test_native_tool_surface.py` and `test_middleware_logging.py` — **93 passed**. - Additional regression tests: `test_middleware.py` and `test_tool_search_transform.py` — **250 passed**. - `pre-commit run --files` on all five branch-changed files — **passed** (including mypy, ruff, and pylint). - Diff whitespace check passed; live head reverified unchanged before posting. No fixes or commits needed; worktree remains clean. Local Superset HTTP health was unavailable, so no live HTTP deployment validation was performed; protocol contract tests ran successfully using the in-process MCP client. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
