codeant-ai-for-open-source[bot] commented on code in PR #45089:
URL: https://github.com/apache/superset/pull/45089#discussion_r4221154443
##########
superset/config.py:
##########
@@ -2481,6 +2481,20 @@ def engine_context_manager( # pylint:
disable=unused-argument
# Other potentially dangerous functions
"pg_sleep",
"pg_terminate_backend",
+ # dblink functions can open separate connections and auto-commit
+ # writes, bypassing the read-only gate entirely
+ "dblink",
+ "dblink_exec",
+ "dblink_connect",
Review Comment:
✅ **CodeAnt verified this suggestion was addressed in subsequent commits and
marked this thread resolved** as of `50f3142`.
Added `dblink_connect_u` and `dblink_send_query` to the denied PostgreSQL
function list.
<sub>If that's not right, unresolve this thread and CodeAnt will leave it
open.</sub>
<!-- codeant-auto-resolve-reply -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
