mikebridge opened a new pull request, #45098:
URL: https://github.com/apache/superset/pull/45098

   ### SUMMARY
   
   Reject malformed explicit time ranges with the existing validation error 
(HTTP 400 for chart-data requests), instead of silently turning them into an 
upper-bound-only query. MCP delegates shorthand validation to the shared 
parser. Valid shorthands, explicit open-ended ranges, `No filter`, and omitted 
ranges with legacy `since`/`until` bounds retain their behavior.
   
   `UPDATING.md` explains the compatibility change: saved charts, filters, 
imports, or API requests with malformed or empty ranges must use a supported 
shorthand, an exact `<start> : <end>` range, or `No filter`.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Not applicable; backend validation change.
   
   ### TESTING INSTRUCTIONS
   
   1. Send a chart-data request using a valid datasource with `time_range` set 
to `2025-03-15 - 2025-04-01`, `2025-03-15:`, lowercase `last week`, an empty 
string, `: 2025-04-01`, or `garbage`. Verify HTTP 400 before query execution.
   2. Verify `2025-03-15 : 2025-04-01`, `2025-03-15 : `, ` : 2025-04-01`, `Last 
week`, and `No filter` retain their documented behavior.
   3. Run the date-parser, MCP time-range validation, and chart-data time-range 
validation unit tests.
   
   Local validation: 141 focused tests passed; 220 caller tests passed with one 
skip; changed-file hooks passed. The full unit suite reported 22,417 passed, 40 
skipped, 2 xfailed, and three known local failures in untouched files (two ARM 
long-double cases and a translation fixture whose PATH omits Python).
   
   ### ADDITIONAL INFORMATION
   
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to