mikebridge opened a new pull request, #45099: URL: https://github.com/apache/superset/pull/45099
### SUMMARY Embedded report tables use the shared chart-data export payload builder, so server-paginated charts apply their configured row limit instead of returning only the saved page. The shared rewrite resets the page offset and removes the row-count query. Preserve the embedded path's use of current chart parameters for Table/Pivot processing, including when saved query-context form data is missing or stale. GET and POST share the existing DataFrame conversion. The screenshot bootstrap and fallback for charts without saved query context remain supported. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Not applicable; report data selection changes. A chart saved on a 20-row page with a 100-row limit previously embedded that page; it requests the configured 100 rows from offset zero after this fix. ### TESTING INSTRUCTIONS 1. Save a Table chart with server pagination enabled, a page size of 20, a row limit of 100, and at least 100 matching records. Save while viewing a later page. 2. Generate a text report containing the chart. Verify it uses the configured row limit from offset zero, consistent with CSV/Excel exports, rather than only the saved page. 3. Verify a non-paginated chart retains its saved limits and Table/Pivot processing still uses the current chart settings when query-context form data is absent or stale. 4. Run `tests/unit_tests/commands/report/execute_test.py` and `tests/unit_tests/utils/csv_tests.py`. Local validation: 321 focused tests and changed-file hooks passed. Pagination regressions exercise payload building, authenticated HTTP request construction, and DataFrame parsing against a fake endpoint; no live report delivery was performed. The full unit suite reported 22,418 passed, 40 skipped, 2 xfailed, and three known local failures in untouched files (two ARM long-double cases and a translation fixture whose PATH omits Python). ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration - [ ] Introduces new feature or API - [ ] Removes existing feature or API 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
