kaya-abdullah opened a new pull request, #45131:
URL: https://github.com/apache/superset/pull/45131
### SUMMARY
Adds a regression test for #36954, as offered in the issue. A Druid virtual
dataset using `JSON_VALUE(... RETURNING BIGINT)` failed with "Unable to parse
SQL" on 5.0.0. sqlglot parses the clause for the Druid dialect since 30.12.0
(tobymao/sqlglot#7771), and the 7.0 branch and master already require a newer
version, so the query works there. This test keeps it that way across future
sqlglot upgrades. It follows the TimescaleDB test added in #40142.
The Postgres variant from the issue still fails and needs a change in
sqlglot, so I left out a closing keyword. Happy to add one if you want the
issue resolved with the Druid case.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A, test only.
### TESTING INSTRUCTIONS
pytest tests/unit_tests/sql/parse_tests.py -k
druid_parses_json_value_returning
The new test passes on master. With sqlglot 30.11.0 installed instead, both
cases fail with the parse error from the issue.
### ADDITIONAL INFORMATION
- [x] Has associated issue: #36954
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
