mikebridge commented on PR #45108: URL: https://github.com/apache/superset/pull/45108#issuecomment-6075418000
Thanks @aminghadersohi, both points were right: the docs ran ahead of what the host does today. Addressed in 01e656cfac, docs only: 1. **Grains, present-tense claims.** The #44454 caveat now comes first, and the filter/time-bound paragraph is worded as the intended contract once that work lands. It also says what the host does today: filter resolution keeps whichever variant of a name it sees last (arbitrary, since `get_dimensions()` returns a set), and the grouping fallback orders the remaining grains by name. 2. **Unenforced uniqueness rules.** `Dimension` and the `SemanticView` summary now say these are provider obligations the host does not currently check: a duplicate `(name, grain)` (the host keeps the last variant it sees) and a metric name that collides with a dimension name. `Grains` notes the same for duplicates. - **Nit (`None` operands).** The `Operator` text now links #45133, and says that until it ships the host passes a `None` operand through with its original operator. No behavior change; the members and mapper tests still pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
