mikebridge commented on PR #45071: URL: https://github.com/apache/superset/pull/45071#issuecomment-6079057348
Thanks for the follow-up [review](https://github.com/apache/superset/pull/45071#pullrequestreview-5464151284). Both remaining test gaps are addressed in `7be89d9d33`. - The unreadable-dependent case includes a dashboard and an active report. Independently changing either permission else-arm to `sa.true()` fails the no-names assertion. - The mixed bulk-delete case asserts exactly one danger toast. Removing the rejected-status guard fails with two calls. - Verification: 900 focused Python tests and all 14 DatasetList behavior tests passed; after restoring the mutations, 31 delete tests and all 14 Jest tests passed again. Changed-file hooks, including frontend type-checking, also passed. This follow-up changes only tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
