mikebridge commented on code in PR #45104:
URL: https://github.com/apache/superset/pull/45104#discussion_r4231471687
##########
superset/semantic_layers/mapper.py:
##########
@@ -1278,7 +1314,7 @@ def _validate_orderby(query_object: ValidatedQueryObject)
-> None:
)
elements = {orderby[0] for orderby in query_object.orderby}
Review Comment:
Thanks, applied your suggestion in a09648e575: only string elements are
checked against the view's metric and dimension names, so a dict order-by
element no longer raises `TypeError`.
Two new mapper tests cover a dict element when
`ADHOC_EXPRESSIONS_IN_ORDERBY` is advertised, and confirm an unknown string
name is still rejected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
