codeant-ai-for-open-source[bot] commented on code in PR #45142:
URL: https://github.com/apache/superset/pull/45142#discussion_r4229861762
##########
superset-frontend/src/features/alerts/AlertReportModal.tsx:
##########
@@ -1864,6 +1940,30 @@ const AlertReportModal:
FunctionComponent<AlertReportModalProps> = ({
const renderFilterValueSelect = (filter: ExtraNativeFilter, idx: number) => {
if (!filter) return null;
+ const filterError = nativeFilterErrors[filter.nativeFilterId ?? ''];
+ if (filterError) {
+ const { error, isNetworkError } = filterError;
+ return (
+ <ErrorMessageWithStackTrace
+ error={error.errors?.[0]}
+ compact
+ fallback={
+ <ErrorAlert
+ errorType={
+ isNetworkError ? t('Network error') : t('Cannot load filter')
+ }
+ message={
+ isNetworkError
+ ? t('Network error while attempting to fetch resource')
+ : t('Sorry, something went wrong. Try again later.')
+ }
+ type="error"
+ compact
+ />
+ }
+ />
+ );
+ }
Review Comment:
**Suggestion:** If a `filter_range` option request fails, this early return
replaces its manual min/max inputs with an error, preventing users from
entering the range.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Logic error`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=43016ce45efc46b3bb4d85a9e6658b24&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=43016ce45efc46b3bb4d85a9e6658b24&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/src/features/alerts/AlertReportModal.tsx
**Line:** 1944:1966
**Comment:**
*Logic Error: If a `filter_range` option request fails, this early
return replaces its manual min/max inputs with an error, preventing users from
entering the range.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45142&comment_hash=4fb12fc7b22a43ffed0df6248e0608d8c2d2d002df5b062d3bf03ac7c01ef300&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45142&comment_hash=4fb12fc7b22a43ffed0df6248e0608d8c2d2d002df5b062d3bf03ac7c01ef300&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
