codeant-ai-for-open-source[bot] commented on code in PR #45140:
URL: https://github.com/apache/superset/pull/45140#discussion_r4228842460
##########
superset-frontend/plugins/plugin-chart-echarts/src/Treemap/transformProps.ts:
##########
@@ -184,13 +184,16 @@ export default function transformProps(
}),
});
const newPath = path.concat(name);
+ // Nested leaves are left without a color so that ECharts derives it
+ // from their parent's color using colorSaturation.
+ const hasOwnColor = !!treeNode.children?.length || path.length === 0;
let item: TreemapSeriesNodeItemOption = {
name,
value,
colorSaturation: COLOR_SATURATION,
itemStyle: {
borderColor: BORDER_COLOR,
- color: colorFn(name, sliceId),
+ ...(hasOwnColor && { color: colorFn(name, sliceId) }),
Review Comment:
**Suggestion:** When a nested leaf has a custom or shared dashboard color,
this skips `colorFn`, so its override is ignored and it inherits its parent’s
shade.
**Assessment:** 🟠 `Major` · 🔁 `Occurrence: Sometimes` · 🏷️ `Logic error`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=6df54a0332854084a5b758336a521847&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=6df54a0332854084a5b758336a521847&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/plugins/plugin-chart-echarts/src/Treemap/transformProps.ts
**Line:** 196:196
**Comment:**
*Logic Error: When a nested leaf has a custom or shared dashboard
color, this skips `colorFn`, so its override is ignored and it inherits its
parent’s shade.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45140&comment_hash=cb6f4bf9c332e9c0a1c9de3c822c1dbf7448a9a14d99dc8188953eeb7912e349&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45140&comment_hash=cb6f4bf9c332e9c0a1c9de3c822c1dbf7448a9a14d99dc8188953eeb7912e349&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
