1cbyc opened a new pull request, #45139:
URL: https://github.com/apache/superset/pull/45139

   ### SUMMARY
   
   Fixes #45137.
   
   Suppresses four full-tree mypy false positives caused by `superset-core`'s 
plain model annotations shadowing SQLAlchemy descriptors through the concrete 
models' MRO. The affected modules are added to the existing mirror-case 
override so the focused ignores remain valid in changed-file checks where 
`superset-core` sources are skipped.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Not applicable; this changes static type-checking only.
   
   ### TESTING INSTRUCTIONS
   
   Run:
   
   ```text
   mypy --check-untyped-defs superset-core/src superset/daos/datasource.py 
superset/commands/security/reset.py 
tests/unit_tests/commands/deletion_retention/test_purge_chart_detach.py
   ```
   
   The command reports no issues across 42 source files. The staged-file 
pre-commit suite also passes, including mypy, Ruff 0.9.7 format/lint, 
auto-walrus, custom pylint, and file-hygiene checks.
   
   ### ADDITIONAL INFORMATION
   
   - [x] Has associated issue: #45137
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   Co-authored-by: insisong <[email protected]>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to