codeant-ai-for-open-source[bot] commented on code in PR #45152:
URL: https://github.com/apache/superset/pull/45152#discussion_r4234248575
##########
superset/commands/dashboard/permalink/create.py:
##########
@@ -118,9 +119,15 @@ def run(self) -> str:
# winner's row is committed by now, so re-read it. Use a locking
read:
# under REPEATABLE READ (e.g. MySQL's default) a plain SELECT keeps
# using the snapshot taken by the lookup above and would not see
the
- # row the winner just committed. If nothing is found, this was not
the
- # expected duplicate, so re-raise.
- entry = KeyValueDAO.get_entry(self.resource, uuid_key,
for_update=True)
+ # row the winner just committed. The lock must be shared, not
exclusive:
+ # on InnoDB each loser's failed insert already holds a shared lock
on
+ # the duplicate index record, so with 3+ concurrent losers
exclusive
+ # (FOR UPDATE) re-reads wait on each other's shared locks and
deadlock.
+ # Nothing below writes to the row. If nothing is found, this was
not
+ # the expected duplicate, so re-raise.
+ entry = KeyValueDAO.get_entry(
+ self.resource, uuid_key, lock=RowLock(read=True)
+ )
Review Comment:
**Suggestion:** With PostgreSQL `REPEATABLE READ`, `FOR SHARE` cannot see a
row committed after the transaction snapshot, so this returns `None` and
re-raises the duplicate-key failure.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Race condition`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=506c932028034821ab4ecc7e3d6eaf30&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=506c932028034821ab4ecc7e3d6eaf30&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/commands/dashboard/permalink/create.py
**Line:** 128:130
**Comment:**
*Race Condition: With PostgreSQL `REPEATABLE READ`, `FOR SHARE` cannot
see a row committed after the transaction snapshot, so this returns `None` and
re-raises the duplicate-key failure.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45152&comment_hash=48c74d5fc28b117b2ff00e32f5ec3f2ebdec9ec166e2579bdec394ed5364b01a&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45152&comment_hash=48c74d5fc28b117b2ff00e32f5ec3f2ebdec9ec166e2579bdec394ed5364b01a&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
