mikebridge opened a new pull request, #45154: URL: https://github.com/apache/superset/pull/45154
### SUMMARY Require data access as well as editorship when updating, deleting, or bulk-deleting semantic views. The commands use the existing view and parent-layer grants, preserving Admin behavior and all-or-nothing batch validation. @aminghadersohi, could you take a look when convenient? ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Not applicable; no UI changes. ### TESTING INSTRUCTIONS With `SEMANTIC_LAYERS` enabled, verify updates, individual deletes, and bulk deletes for editors with a view grant or parent-layer grant, and for Admin. Confirm that a refused batch leaves all selected views unchanged. Run the regression tests: ```bash python -m pytest tests/unit_tests/commands/semantic_layer/view_data_access_test.py -q ``` - Regression tests: 13 passed. - Focused semantic-layer verification and changed-file pre-commit checks passed. - Full unit suite: 24,221 passed; 6 accepted local baseline failures involving platform numeric precision, timezone data, and fixture PATH. CI remains authoritative. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [x] Required feature flags: `SEMANTIC_LAYERS` - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
