TryingtoLiveInTech commented on PR #44991: URL: https://github.com/apache/superset/pull/44991#issuecomment-6095017754
Thanks for the review, @rebenitez1802! Pushed f96a984ed8: 1. **Unresolved placeholders**: the sort now runs on the merged list (resolved permissions plus ID placeholders), and the earlier sort in the fetch step is gone, so there's one sort. A new modal test covers a role where only some IDs resolve. 2. **Tie-breaking**: `getSearchMatchRank` is replaced by a criterion-by-criterion comparison that matches `rankedSearchCompare`, so lower criteria still break ties before natural ordering. The comment now says "same order as" instead of "mirroring". 5. **`ReactNode` label typing**: leaving this as is for now, since labels always come from `formatPermissionLabel`. Happy to tighten it in a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
