codeant-ai-for-open-source[bot] commented on code in PR #45172:
URL: https://github.com/apache/superset/pull/45172#discussion_r4238553220
##########
superset-frontend/plugins/plugin-chart-echarts/test/Timeseries/transformProps.test.ts:
##########
@@ -1466,6 +1466,36 @@ test('moves a visible horizontal Plain legend into a
custom HTML legend and rest
expect('contentHeight' in transformed).toBe(false);
});
+test('hides legend selector buttons when showSelectorLegend is false', () => {
+ const plain = transformProps(
+ createTestChartProps({
+ formData: {
+ ...formData,
+ legendOrientation: LegendOrientation.Top,
+ legendType: LegendType.Plain,
+ showLegend: true,
+ showSelectorLegend: false,
+ },
+ }),
+ );
+ expect(getCustomLegend(plain)?.showSelectors).toBe(false);
+
+ const scroll = transformProps(
+ createTestChartProps({
+ formData: {
+ ...formData,
+ legendOrientation: LegendOrientation.Top,
+ legendType: LegendType.Scroll,
+ showLegend: true,
+ showSelectorLegend: false,
+ },
+ }),
+ );
+ expect((scroll.echartOptions.legend as { selector?: unknown
}).selector).toBe(
+ false,
+ );
Review Comment:
✅ **CodeAnt verified this suggestion was addressed in subsequent commits and
marked this thread resolved** as of `69e2370`.
The test checks that `selectorLabel.show` is false for the scroll legend,
matching the label visibility setting returned by `getLegendProps`.
<sub>If that's not right, unresolve this thread and CodeAnt will leave it
open.</sub>
<!-- codeant-auto-resolve-reply -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
