sadpandajoe commented on code in PR #44965:
URL: https://github.com/apache/superset/pull/44965#discussion_r4237815882
##########
superset-frontend/webpack.config.js:
##########
@@ -107,6 +106,21 @@ const output = {
pathData.chunk?.name === 'service-worker'
? '../service-worker.js'
: defaultChunkFilename,
+ copy: [
Review Comment:
Moving these patterns into `output.copy` drops them from Storybook:
`.storybook/main.mjs:104-132` merges `customConfig.plugins` but not
`customConfig.output`, and its `staticDirs` only covers `src/assets/images`.
Before, `CopyPlugin` rode along in those plugins, so `maplibre-gl-worker.mjs`
and `maplibre-gl-shared.mjs` landed in the Storybook output; now the
point-cluster map story's
`setWorkerUrl(`${__webpack_public_path__}maplibre-gl-worker.mjs`)` request 404s
and the basemap cannot load. Should Storybook's `webpackFinal` also carry
`customConfig.output.copy` (or list the two maplibre-gl dist files in
`staticDirs`)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
