sadpandajoe commented on code in PR #45198:
URL: https://github.com/apache/superset/pull/45198#discussion_r4242266473
##########
superset-frontend/plugins/plugin-chart-chord/package.json:
##########
@@ -29,7 +29,7 @@
"access": "public"
},
"dependencies": {
- "d3": "^3.5.17",
+ "d3": "^7.9.0",
Review Comment:
Bumping `d3` to ^7 here, and in the country-map, partition and world-map
plugins, with no source changes will break these four charts at load time.
Their `src` still does `import d3 from 'd3'` and calls v3-only APIs
(`d3.layout.chord`, `d3.svg.arc`/`d3.svg.chord` in `Chord.ts`;
`d3.scale.linear`, `d3.mouse`, `d3.event` in `Partition.ts`; `d3.geo.path`,
`d3.geo.centroid`, `d3.event` in `CountryMap.ts`; `d3.event` in `WorldMap.ts`).
v7 has no default export and none of those namespaces, and `d3.event` is gone,
so Chord, Partition, Country Map and World Map would fail on render. The two
failing `sharded-jest-tests` shards look like the same thing. Should this stay
on v3, or is the migration of these four plugins meant to land with the bump?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
