FrancescoCastaldi commented on PR #45186: URL: https://github.com/apache/superset/pull/45186#issuecomment-6110169403
@sadpandajoe All review points have been addressed in the latest commits (0ec4b68 and eb21148): - Restored strict floors cryptography>=50.0.2, <51.0.0 and msgpack>=1.2.3, <1.3 in pyproject.toml. - Aligned PyArrow remediation floor to >=25.0.1 and updated the remediation Dockerfile snippet to install directly into the container virtual environment (/app/.venv). - Added unit tests covering the TypeError fallback to default_backend() and CertificateException mapping in parse_ssl_cert. - Updated check_security_dependencies.py and test_dependency_security_constraints.py to dynamically parse active requirements from requirements/base.in. - Added reproduction test demonstrating the historic Superset 6.1.0 conflict vs current resolution. All test suites and Astral Ruff checks pass cleanly (11/11 tests green). Whenever you have a moment, could you please take another look and re-review? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
