rusackas commented on PR #40456: URL: https://github.com/apache/superset/pull/40456#issuecomment-6114124004
Checking back in on this one, and thanks for the fix. I think the situation has changed since you opened it. #36605 moved the write in `histogram.py` to `df.loc[:, column] = ...`, and that no longer trips `SettingWithCopyWarning`. @aminghadersohi verified on the current head that even a real sliced fixture passes with `.copy()` removed, so there's no test we can write that would catch a regression here. That also means the thing @sadpandajoe asked for can't be done anymore, and #36530 looks fixed on master already. Tempted to close this as superseded, but curious whether you're still seeing the warning on a recent master. If you are, a repro would be great and we can take another look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
