FrancescoCastaldi commented on PR #45039: URL: https://github.com/apache/superset/pull/45039#issuecomment-6114721959
Hi @sadpandajoe @richardfogaca, All four review items are in place on this PR (store configuration lookup via `state.common?.conf`, custom selection retention with 1-second presets via `lastEmittedCustomValueRef`, `oxfmt` formatting with `arrowParens: "avoid"`, and negative draft clamping). All 18 unit tests in `RefreshFrequencySelect.test.tsx` pass cleanly. Whenever you have a chance, please take a look for re-review. Thank you! @coderabbitai review @bito-code-review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
