rusackas commented on PR #44280: URL: https://github.com/apache/superset/pull/44280#issuecomment-6123909530
Thanks @eschutho, this is shaping up nicely. It has conflicts with `master` now (looks like `messages.pot` again), so it needs a rebase before it can merge. Also, some of the codeant threads are still open. The secret key masking one looks covered by the `visibilityToggle` commit, so that should be a quick resolve. The PrivateLink host one looks worth a real look, since saving would reconstruct an `athena.`-prefixed endpoint. Could you assess those and resolve them, then I'll take another look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
