rusackas commented on PR #44282: URL: https://github.com/apache/superset/pull/44282#issuecomment-6123919479
Thanks @eschutho, nice to see Trino get the dynamic form. However, codeant's thread on `adjust_engine_params` looks valid to me: with `setdefault`, an existing `http_scheme: "http"` in `connect_args` beats an explicit Encrypt toggle, so someone could tick the box and still go out over HTTP. Should the toggle win, or only defer when the existing value is already `https`? The test that pins the current behavior would need to change either way. The duplicated field components Bito flagged are fine by me as-is. Otherwise LGTM! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
