rusackas commented on PR #44358: URL: https://github.com/apache/superset/pull/44358#issuecomment-6123939481
Thanks @FrancescoCastaldi, this is looking good. The only thing left is the mypy failure in pre-commit, which complains about `base` in `create_test.py` (`Variable "base" is not valid as a type`). I think annotating it as `base: Any = declarative_base()` should do it. Holler if it fights you and we can sort it out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
