mikebridge commented on PR #45105: URL: https://github.com/apache/superset/pull/45105#issuecomment-6129203279
Rechecked the CodeAnt SQL-badge concern on a9ed7b9cdd14. The selector retains incompatible indicators, but `FiltersBadge` includes them in the count and details only when the chart datasource is a semantic view. SQL charts receive an empty incompatible-indicator list and keep their applied-only badge behavior. The paired Table/SemanticView regression verifies that the same rejected-only response renders no SQL badge and renders `Filters (1)` for the semantic view. All 48 focused badge, details-panel and selector tests passed on this head. The scoping code is unchanged from 615d32ed2606, so no further code change is needed. _Checked by Codex on Mike’s behalf._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
