aminghadersohi commented on code in PR #44657:
URL: https://github.com/apache/superset/pull/44657#discussion_r4247604538
##########
superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/utilities.ts:
##########
@@ -480,12 +553,36 @@ const baseAggregatorTemplates = {
return function () {
return {
sum: 0 as any,
+ // Tracks whether every pushed value was a SQL NULL, so a fraction
+ // aggregator can keep an all-null scope blank instead of 0.
Review Comment:
Verified at b5855ec: an all-NULL Sum subtotal now renders blank, and the new
`run("Sum", [null, null])` assertion fails if `value()` reverts to `this.sum`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
