rusackas commented on PR #44307: URL: https://github.com/apache/superset/pull/44307#issuecomment-6123936434
Thanks @kokhlo, the empty-slug fix looks good and CI is green now. One thing left before I can approve though... EnxDev's open thread about soft-deleted dashboards. If the incoming UUID belongs to a soft-deleted row, `import_dashboard()` takes the restore path and never resolves by slug, so a live dashboard that picked up the old slug would trigger an OVERWRITE prompt that then dead-ends in the "cannot be restored via re-import" error. Skipping the slug check whenever a row (live or soft-deleted) already has that UUID looks like the right call, plus a soft-deleted test case to pin it. Could you take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
