FrancescoCastaldi commented on code in PR #45205:
URL: https://github.com/apache/superset/pull/45205#discussion_r4256409077
##########
tests/unit_tests/db_engine_specs/test_crdb.py:
##########
@@ -58,3 +58,41 @@ def test_dialect_loads_under_installed_sqlalchemy() -> None:
from sqlalchemy import create_engine
create_engine("cockroachdb://root@localhost:26257/defaultdb?sslmode=disable")
+
+
+def test_cockroachdb_properties() -> None:
+ from superset.db_engine_specs.cockroachdb import CockroachDbEngineSpec
+ from superset.db_engine_specs.postgres import PostgresEngineSpec
+
+ assert CockroachDbEngineSpec.engine == "cockroachdb"
+ assert CockroachDbEngineSpec.engine_name == "CockroachDB"
+ assert issubclass(CockroachDbEngineSpec, PostgresEngineSpec)
+ assert CockroachDbEngineSpec._extended_aggregations == {}
+
+
+def test_cockroachdb_metadata() -> None:
+ from superset.db_engine_specs.cockroachdb import CockroachDbEngineSpec
+
+ metadata = CockroachDbEngineSpec.metadata
+ assert "CockroachDB is a distributed SQL database" in
metadata["description"]
Review Comment:
Pruned the static copy string mirror tests across CockroachDB and OceanBase
while preserving the behavioural assertions (_extended_aggregations == {},
engine subclassing, and dialect properties) in commit 1ce6590.
##########
tests/unit_tests/db_engine_specs/test_crdb.py:
##########
@@ -58,3 +58,41 @@ def test_dialect_loads_under_installed_sqlalchemy() -> None:
from sqlalchemy import create_engine
create_engine("cockroachdb://root@localhost:26257/defaultdb?sslmode=disable")
+
+
+def test_cockroachdb_properties() -> None:
+ from superset.db_engine_specs.cockroachdb import CockroachDbEngineSpec
+ from superset.db_engine_specs.postgres import PostgresEngineSpec
+
+ assert CockroachDbEngineSpec.engine == "cockroachdb"
+ assert CockroachDbEngineSpec.engine_name == "CockroachDB"
+ assert issubclass(CockroachDbEngineSpec, PostgresEngineSpec)
+ assert CockroachDbEngineSpec._extended_aggregations == {}
+
+
+def test_cockroachdb_metadata() -> None:
+ from superset.db_engine_specs.cockroachdb import CockroachDbEngineSpec
+
+ metadata = CockroachDbEngineSpec.metadata
+ assert "CockroachDB is a distributed SQL database" in
metadata["description"]
+ assert metadata["logo"] == "cockroachdb.png"
+ assert "sqlalchemy-cockroachdb" in metadata["pypi_packages"]
+ assert metadata["default_port"] == 26257
+
+
[email protected](
+ "target_type,expected_result",
+ [
+ ("Date", "'2019-01-02'"),
+ ("DateTime", "'2019-01-02 03:04:05'"),
+ ("UnknownType", None),
+ ],
+)
+def test_cockroachdb_convert_dttm(
Review Comment:
Consolidated DateTime into the primary test_convert_dttm parametrize block
and added coverage for String and Text types (exercising the types.String
branch) in commit 1ce6590.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
