aminghadersohi commented on PR #45148: URL: https://github.com/apache/superset/pull/45148#issuecomment-6142224777
Verified every observation in EnxDev's 2026-10-13 08:05 review: https://github.com/apache/superset/pull/45148#pullrequestreview-5500538539 All are already satisfied at head 5b48ec5dd771d3642b0f15ea02d0c1c3dbb965e7; the review requests no changes: 1. **Truncated pages carry a cursor:** `build_catalog_page` starts with `truncated=False`; only the byte-bound loop sets it true through `_page(count, True, truncated=True)`. The loop retains at least one item, so cursor generation always succeeds (`get_catalog.py:382–401`). 2. **Shortening flags describe retained items:** `fields_shortened=any(shortened_flags[:count])` uses only the returned prefix (`get_catalog.py:391`). 3. **Regression assertions apply on every visited page:** `_walk` asserts truncated implies a cursor, and no cursor implies not truncated, inside its pagination loop (`test_get_catalog.py:955–962`). REST review comments and GraphQL reviewThreads are both empty; there are no inline threads to reply to or resolve, and no top-level EnxDev issue comments. Validation: `.venv/bin/python -m pytest tests/unit_tests/mcp_service/catalog/tool/test_get_catalog.py -q` — **84 passed**. Pre-commit on all four PR-changed files and explicit mypy — **passed**. No code changes, new commit, or push needed. Master is 87 commits ahead, but the PR is mergeable and all completed CI checks are successful, skipped, or neutral; review approval is still required. Left the reviewed head unchanged rather than adding an unrelated merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
