rusackas commented on PR #41285: URL: https://github.com/apache/superset/pull/41285#issuecomment-6142650161
Thanks @EnxDev, the last push (the awaited `userEvent.type` in the add-tab test) got CI green, so the red you saw on the earlier head should be gone. The localStorage cleanup on tab close is a fair nit, but I'd rather not hold this up for it. Happy to do it as a follow-up if you feel strongly. The `hold!` label is what's blocking merge now, so if you think this isn't particularly controversial and can advocate for it in the Extensions working group, maybe it's OK to remove that and merge it? Or do you think we need a SIP for this (cc @michael-s-molina / @villebro) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
