rusackas commented on PR #36214: URL: https://github.com/apache/superset/pull/36214#issuecomment-6150111891
Pushed a follow-up that should close out all three of your points. `classifyNaturalSortMode` now picks one strategy (integer/numeric/lexicographic) for the whole column up front, so `naturalCompare` can't flip-flop pair-to-pair anymore. The natural sort runs before `rebaseToPercentChange`, so the 0% baseline matches the sorted, on-screen leftmost category. And it skips entirely when `x_axis_sort` already orders by a metric, mirroring the same groupby-empty condition `sortOperator` checks, so that choice isn't silently discarded. Added tests for all three, and rebased since `master` had drifted again. @sadpandajoe mind giving it another look when you get a chance? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
