rusackas commented on PR #44558: URL: https://github.com/apache/superset/pull/44558#issuecomment-6150844725
Nothing to add on top of @gabotorresruiz's review, honestly, that was about as thorough a pass as this gets. Re-ran the suite myself and traced the executor, the `Forbidden` mapping, and the new byte-bounded guard, and it all holds up. A couple of small things that shouldn't hold this up, left as suggestions. One more that doesn't land in this diff so I can't suggest it inline: `DEFAULT_INSTRUCTIONS` in `app.py` still only mentions ASCII/URL/table/Vega-Lite, not the new `png` format, which the MCP README's own checklist calls for. Worth a quick follow-up whenever you're back in here. Approving. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
