aminghadersohi commented on PR #45242: URL: https://github.com/apache/superset/pull/45242#issuecomment-6155213955
Addressed the cache note in https://github.com/aminghadersohi/superset/commit/ede52e48dc2336b4efdb547ce9d7fc02d8adbf37 The distinct-values read now goes through the same data_cache path as the column-values API. I extracted the cache read/query/write into a shared helper, get_cached_column_values in superset/datasource/api.py, and both the endpoint and apply_dashboard_filters call it, so they share entries (same key, same timeout). The CONTAINS searches use it too, with the API's 60s search timeout. The key is still partitioned by effective RLS, dataset uid and changed_on, and the dataset access check still runs before any read, so cached values are not shared across users with different RLS. Added tests for cache hits skipping the query, reuse of entries written by the API, RLS/dataset scoping, and no cache read when access is denied. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
