hainenber commented on code in PR #45155: URL: https://github.com/apache/superset/pull/45155#discussion_r4260087931
########## superset-frontend/.npmrc: ########## @@ -1 +1,2 @@ min-release-age=3 +ignore-scripts=true Review Comment: That's actually a good point there, thanks @EnxDev! [npm 12 will disable install scripts by default](https://github.blog/changelog/2026-06-09-upcoming-breaking-changes-for-npm-v12/)) so I guess I'm doing a bit of premature future-proofing here. I've created https://github.com/scarf-sh/scarf-js/issues/84 so that maybe in the future, they'll find a way to migrate off `postinstall` script Wdyt @rusackas? I'm happy with closing this PR since having telemetry collected is still crucial, I understand that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
