CodeWithPravinMaske commented on issue #26651: URL: https://github.com/apache/superset/issues/26651#issuecomment-6164814918
@sfirke thanks, and fair point on process. I'm happy to follow whatever sequencing the SIP prefers, including holding #44527 until the vote. On your question (how much extra work later if we ship a separate filter now): from reading the code, I'd expect it to be small. - The value is already compatible. The filter emits the same `since : until` date text the Time range filter's parser accepts, so combining them later needs no data conversion. - What would change: saved dashboards store the type name `filter_date_range`, so that needs an alias or a small migration; the Alerts & Reports handling I added (`reports/models.py`, `AlertReportModal.tsx`) would fold into the existing `filter_time` handling; and the plugin folder would be removed. - One decision either way: this picker shows the end date inclusive (it stores end + 1 day, since the backend end bound is exclusive), while Custom range shows the end as exclusive. A combined filter has to pick one convention. I haven't prototyped the merge, so this is from reading the code, not a tested estimate. So the options as I see them: 1. Ship #44527 as a separate, additive filter now, with the follow-up (a Calendar mode inside the Time range control, as in @andy-clapson's revised SIP) tracked here, and an alias for `filter_date_range` when that lands. 2. Rework #44527 to go with the SIP's Part 1: add the calendar picker as a mode of the existing Time range control, not a new filter type. That changes a core control used by existing dashboards, so I'd want agreement first. 3. A middle path: keep a single filter type but add a "Calendar (date only)" display option to the existing Time range filter's settings. I'd need to check how much of the current Time range filter code that touches. I'm happy to do 2 or 3 if that's the preferred direction. Which would you and @rusackas like? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
