Aitema-gmbh commented on PR #39239: URL: https://github.com/apache/superset/pull/39239#issuecomment-6171585024
Hi @rusackas — thanks for picking this back up, and no worries about the re-ask. I've rebased onto current master and squashed it to a single commit, so it's mergeable again. The deck.gl Tooltip merged cleanly; the only conflict was in `TaskPayloadPopover`, where I kept master's new Results/Internal sections and put the Escape handler next to them. The related Jest suites pass locally, and the formatting checks pass under oxfmt. I've also sent you a collaborator invite to aitema-de/superset (it should be waiting at https://github.com/aitema-de/superset/invitations), so you can rebase or adjust our other a11y PRs yourself whenever master moves. Several of them have picked up conflicts again since the summer. #39233 (1.4.1) and #39235 (1.4.4) are still conflict-free and ready for review. Thanks again for shepherding these! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
