dpgaspar commented on a change in pull request #8773: re-enable Pylint on a
number of view files
URL:
https://github.com/apache/incubator-superset/pull/8773#discussion_r355976536
##########
File path: superset/views/datasource.py
##########
@@ -100,8 +98,8 @@ def external_metadata(self, datasource_type=None,
datasource_id=None):
database = (
db.session.query(Database).filter_by(id=request.args.get("db_id")).one()
)
- Table = ConnectorRegistry.sources["table"]
- datasource = Table(
+ table = ConnectorRegistry.sources["table"]
Review comment:
I'm actually starting to use `table_cls` style, so +1 on that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
