willbarrett commented on a change in pull request #8770: Re-enable pylint for some model files URL: https://github.com/apache/incubator-superset/pull/8770#discussion_r356169845
########## File path: .pylintrc ########## @@ -115,7 +115,7 @@ evaluation=10.0 - ((float(5 * error + warning + refactor + convention) / stateme [BASIC] # Good variable names which should always be accepted, separated by a comma -good-names=i,j,k,ex,Run,_,d,e,v,o,l,x,ts,f +good-names=i,j,k,ex,Run,_,d,e,v,o,l,x,ts,f,id Review comment: I added the global disable to avoid doing inline disables for all of the models that have an `id` column (read: all of them). Perhaps I should do a top-level disable at the files containing models instead? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
